Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore(wren-ui): wait ai service ready before open browser #220

Merged
merged 4 commits into from
May 10, 2024

Conversation

@onlyjackfrost onlyjackfrost requested a review from wwwy3y3 May 8, 2024 13:19
@wwwy3y3
Copy link
Member

wwwy3y3 commented May 9, 2024

@onlyjackfrost since you expose AI port to do health check, I'm thinking we should do port checking and port changing as well

Copy link
Member

@wwwy3y3 wwwy3y3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wwwy3y3 wwwy3y3 merged commit 5b0c3f6 into main May 10, 2024
2 checks passed
@wwwy3y3 wwwy3y3 deleted the chore/launcher-wait-ai-service branch May 10, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants