Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wren-ui): Backend API provide error message from wren engine #222

Merged
merged 4 commits into from
May 13, 2024

Conversation

andreashimin
Copy link
Contributor

Description

We need to provide wren-engine error message when the user is creating or updating the calculated field.
At least to know the error message for debugging.

UI Screenshot

Pasted image 20240508170016
  • collapse

    Pasted image 20240508165833

Copy link
Member

@wwwy3y3 wwwy3y3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on backend.

@andreashimin andreashimin force-pushed the feature/add-engine-error-to-client branch from 8040d9b to 96bd4c4 Compare May 10, 2024 10:50
@andreashimin
Copy link
Contributor Author

andreashimin commented May 10, 2024

Rebase & resolve conflicts with #228

Copy link
Contributor

@onlyjackfrost onlyjackfrost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wwwy3y3 wwwy3y3 merged commit 4d18594 into main May 13, 2024
3 checks passed
@wwwy3y3 wwwy3y3 deleted the feature/add-engine-error-to-client branch May 13, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants