Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature(wren-ui): Implement Preview model data #229

Merged
merged 1 commit into from
May 10, 2024
Merged

Conversation

onlyjackfrost
Copy link
Contributor

@onlyjackfrost onlyjackfrost commented May 10, 2024

Schema

mutation PreviewModelData($where: WhereIdInput!) {
  previewModelData(where: $where)
}
{
  "where": {
    "id": int
  }
}

const sql = `select * from ${model.referenceName}`;
const data = await ctx.wrenEngineAdaptor.previewData(
sql,
PREVIEW_MAX_OUTPUT_ROW,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @andreashimin & @fredalai , only 100 rows will return to frontend for model preview as well

Copy link
Member

@wwwy3y3 wwwy3y3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wwwy3y3 wwwy3y3 merged commit f700279 into main May 10, 2024
@wwwy3y3 wwwy3y3 deleted the feature/preview-model branch May 10, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants