Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: caching layer persistent #283

Merged
merged 4 commits into from
Aug 18, 2023

Conversation

onlyjackfrost
Copy link
Contributor

@onlyjackfrost onlyjackfrost commented Aug 18, 2023

Description

  • Make caching layer datasource can be persistent
    • It's will reduce the memory usage when loading parquet file to cache
  • Skip exporting data if parquet file exists when loading cache
    • avoid exporting/downloading data if the parquet files in path is still fresh

@vercel
Copy link

vercel bot commented Aug 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vulcan-sql-document ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 18, 2023 9:54am

@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.05% 🎉

Comparison is base (de4fb81) 90.09% compared to head (453d8a5) 90.14%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #283      +/-   ##
===========================================
+ Coverage    90.09%   90.14%   +0.05%     
===========================================
  Files          353      353              
  Lines         6077     6090      +13     
  Branches       824      829       +5     
===========================================
+ Hits          5475     5490      +15     
+ Misses         440      438       -2     
  Partials       162      162              
Flag Coverage Δ
build 89.57% <ø> (ø)
core 93.96% <100.00%> (+0.03%) ⬆️
extension-api-caller 90.00% <ø> (ø)
extension-authenticator-canner 78.37% <ø> (ø)
extension-dbt 97.43% <ø> (ø)
extension-debug-tools 98.11% <ø> (ø)
extension-driver-bq 84.93% <ø> (ø)
extension-driver-canner 84.65% <ø> (ø)
extension-driver-clickhouse 88.09% <ø> (ø)
extension-driver-duckdb 91.80% <ø> (ø)
extension-driver-ksqldb 90.33% <ø> (+0.84%) ⬆️
extension-driver-pg 96.11% <ø> (ø)
extension-driver-snowflake 96.26% <ø> (ø)
extension-huggingface 86.25% <ø> (ø)
extension-store-canner 97.54% <ø> (ø)
integration-testing 90.27% <ø> (ø)
serve 87.17% <ø> (ø)
test-utility ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
packages/core/src/models/artifact.ts 91.66% <ø> (ø)
packages/core/src/containers/modules/dataSource.ts 95.65% <100.00%> (ø)
...kages/core/src/lib/cache-layer/cacheLayerLoader.ts 100.00% <100.00%> (ø)
packages/core/src/models/cacheLayerOptions.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@onlyjackfrost onlyjackfrost force-pushed the feature/caching-layer-persistent branch from 9505a8a to 453d8a5 Compare August 18, 2023 09:36
@onlyjackfrost onlyjackfrost changed the title [DRAFT] caching layer persistent Fix: caching layer persistent Aug 18, 2023
Copy link
Contributor

@andreashimin andreashimin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines 97 to 102
const parquetFiles = [];
for (const file of files) {
if (/\.parquet$/.test(file)) {
parquetFiles.push(file);
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(NIT) Prefer functional programming for filtering

const parquetFiles = files.filter(file => /\.parquet$/.test(file))

@onlyjackfrost onlyjackfrost merged commit fc74f55 into develop Aug 18, 2023
5 checks passed
@hanshino hanshino deleted the feature/caching-layer-persistent branch January 31, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants