Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Evict unused parquet file after exporting cache data #290

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

onlyjackfrost
Copy link
Contributor

@onlyjackfrost onlyjackfrost commented Aug 29, 2023

Description

Remove the dormant Parquet files to free up hardware storage as these files are no longer required.

Test

Using playground to test, under the tmp/artist-artist/canner/lineitem folder, the elder parquet files were evict after exporting data successfully.
image

@vercel
Copy link

vercel bot commented Aug 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vulcan-sql-document ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2023 6:57am

@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2023

Codecov Report

Patch coverage is 100.00% of modified lines.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Files Changed Coverage
...kages/core/src/lib/cache-layer/cacheLayerLoader.ts 100.00%

📢 Thoughts on this report? Let us know!.

Copy link
Contributor

@kokokuo kokokuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect ! LGTM 👍

@kokokuo kokokuo merged commit c60ab59 into develop Aug 30, 2023
5 checks passed
@kokokuo kokokuo deleted the feature/evict-expired-parquet-files branch August 30, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants