Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DuckDB Connection Pool Initialization Issue #319

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

JSYOU
Copy link
Contributor

@JSYOU JSYOU commented Oct 23, 2023

Description

This PR addresses an issue where the connection pool in DuckDB queries might fail due to incorrect initialization. The problem has been resolved, ensuring that the connection pool is properly initialized.

Issue ticket number

n/a

Additional Context

@vercel
Copy link

vercel bot commented Oct 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vulcan-sql-document ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2023 9:05am

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Files Coverage Δ
...xtension-driver-duckdb/src/lib/duckdbDataSource.ts 89.26% <100.00%> (-0.15%) ⬇️
...ion-driver-duckdb/src/lib/duckdbExtensionLoader.ts 70.00% <76.47%> (-2.73%) ⬇️

📢 Thoughts on this report? Let us know!.

Copy link
Contributor

@kokokuo kokokuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kokokuo kokokuo marked this pull request as ready for review October 24, 2023 09:59
@kokokuo kokokuo merged commit 541bcfa into develop Oct 24, 2023
6 checks passed
@hanshino hanshino deleted the fix/duckdb-connection-pool-initialization-issue branch January 31, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants