-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ibis server #545
Add Ibis server #545
Conversation
957ac9d
to
04b72ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. LGTM.
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just take a note:
I notices that there're different number of empty line between functions or classes. I think we may can find some solution to format the code. To ensure everyone has same coding style.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@goldmedal @grieve54706 I recommend using ruff. https://github.com/astral-sh/ruff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I use Intellij IDEA that follows the PEP8. It's a regular coding style.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommend using ruff. https://github.com/astral-sh/ruff
Nice idea, I will add it in the future.
Add a python server for ibis-project/ibis
Query data API
Path parameters
data_source: string,
required
. The name of the data source to query.The available values*:*
Request body
required
Other fields determined by data source
For Postgres:
required
required
required
required
For Bigquery:
required
required
credentials.json
For Snowflake:
required
required
required
required
Response body