Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to add blobs for TLS #20

Merged
merged 7 commits into from
Jan 10, 2019
Merged

Ability to add blobs for TLS #20

merged 7 commits into from
Jan 10, 2019

Conversation

joedborg
Copy link
Contributor

lib/charms/layer/docker_registry.py Outdated Show resolved Hide resolved
Copy link
Contributor

@kwmonroe kwmonroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lookin good, but I think we're missing a couple corner cases:

  • _write_tls_blobs_to_files should return or block with a message about invalid config if tls-*-path config vars aren't truthy
  • config should override the cert-provider relation, so in the reactive code, we should update the cert handlers so they only fire @when_not(config.set.tls-*-blob)
  • need a new reactive handler @when(config.set.tls-*-blob) that sets charm.docker-registry.tls-enabled and calls configure. this is how clients know that registry comms should go over https.

lib/charms/layer/docker_registry.py Outdated Show resolved Hide resolved
Copy link
Contributor

@kwmonroe kwmonroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't return false in configure_registry since tls is optional. Also, we still need reactive handlers to ensure config overrides relation data.

lib/charms/layer/docker_registry.py Outdated Show resolved Hide resolved
lib/charms/layer/docker_registry.py Outdated Show resolved Hide resolved
lib/charms/layer/docker_registry.py Outdated Show resolved Hide resolved
@kwmonroe kwmonroe merged commit 783d4ae into canonical:master Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants