-
-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ANSI codes inserted into the prompt after starting broot (causing "No matching verb") #854
Comments
This is related to the test of terminal colors. Assuming you're using version 1.36 of broot, can you please see if it happens for you with version 1.32 ? |
You are right, this problem does not occur on 1.32.0 Kapture.2024-03-10.at.12.00.19.mp4For reference, I am using kitty 0.32.2 |
@Gelio I don't know if you're able to compile things for rust. If so, I would appreciate if you could test the example of https://github.com/Canop/xterm-query/ which is executed with |
What's your terminal and OS exactly ? |
Strange. Ironically my commit in xterm-query introducing this issue is exactly the solution to the symptoms here (at least on Linux) that I reported in Canop/terminal-light#4. |
Terminal: kitty 0.32.2 OS: macOS Sonoma 14.2.1 |
@Gelio Thanks for providing the example run. I was about to reproduce this issue. I think Canop/xterm-query#4 fixes this since I'm not able to reproduce the issue when using the branch of that PR. |
@Gelio just out of curiosity, was broot working fine on Mac before recently? |
I checked out that commit and it looks like the problem is fixed for me on kitty Kitty in tmux: ![]() Kitty outside of tmux (says image protocol is supported, as expected): ![]() Interestingly, the macOS Terminal app still has the extra characters: ![]()
I switched to Mac recently and I can't tell, as I haven't used broot a lot recently :/ sorry |
Nice! Thanks so much for testing.
That's just the Terminal app being silly AFAICT. If you revert the commit to before my recent changes (
No worries. I can verify that at least kitty worked fine before my recent changes. My own app ( |
Same issue for iTerm in macOS |
After starting
br
orbroot
in my terminal, I see the following ANSI codes inserted immediately:It says:
11;rgb:2828/2a2a/3636
This happens regardless of whether I run the command in zsh, bash (with the default bash prompt), inside or outside tmux.
The only difference is that when I run it outside tmux, broot does not say "No matching verbs", but it behaves as if the sequence was not there:
I am not sure what is causing this. I would appreciate any tips to debug this issue.
The text was updated successfully, but these errors were encountered: