Use polling syscall directly to fix MacOS support #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 10, 2024
|
Re-posting the comment from Canop/broot#854 (comment) I checked out this PR and it looks like the problem is fixed for me on kitty Kitty in tmux: 
Kitty outside of tmux (says image protocol is supported, as expected): 
Interestingly, the macOS Terminal app still has the extra characters: 
|
On MacOS, `poll` and `kqueue` are not supported for tty[1]. So let's ditch mio completely and directly call `select` ourselves. On non-MacOS, we use `poll` to avoid limitation of `select` that is limited to FDs below 1024. If the process has a lot of open FDs, we could end up with an FD higher than 1023 and get an error. This fixes MacOS support. [1]: tokio-rs/mio#1377
zeenix
force-pushed
the
use-select-on-mac
branch
from
2e40418
to
1cf5407
Compare
|
I find no problem, so I'm probably going to merge that. No remaining doubt ? |
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On MacOS,
pollandkqueueare not supported for tty1. So let's ditch mio completely and directly callselectourselves.On non-MacOS, we use
pollto avoid limitation ofselectthat is limited to FDs below 1024. If the process has a lot of open FDs, we could end up with an FD higher than 1023 and get an error.This fixes MacOS support.
Fixes #3.
This replaces #2.