Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tutorial on reaction rate parameterizations #213

Merged
merged 1 commit into from
Jun 19, 2022

Conversation

ischoegl
Copy link
Member

Update portion of tutorial covering reaction rates

Closes #212

@ischoegl ischoegl force-pushed the update-rate-tutorial branch 2 times, most recently from 45c7881 to a7214e4 Compare June 18, 2022 17:19
@ischoegl
Copy link
Member Author

ischoegl commented Jun 18, 2022

@bryanwweber ... is there a way to get Sphinx to recognize :py:attr:`ReactionRate.input_data` ? (it is a property) ... as far as I am aware, it is a legitimate tag, but the website apparently doesn't support it ...

@bryanwweber
Copy link
Member

@ischoegl Can I suggest we defer fixing that until after #209, #210, and #211 land? I suspect it's an issue with the Nikola/Sphinx bridge, and hopefully once we get everything into Sphinx it'll be easier.

@ischoegl
Copy link
Member Author

@bryanwweber ... np. I skipped the link for the time being, but left a note.

Copy link
Member

@bryanwweber bryanwweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix @ischoegl!

@bryanwweber bryanwweber merged commit 889ac30 into Cantera:main Jun 19, 2022
@ischoegl ischoegl deleted the update-rate-tutorial branch September 1, 2022 14:16
@ischoegl ischoegl restored the update-rate-tutorial branch September 1, 2022 14:16
@ischoegl ischoegl deleted the update-rate-tutorial branch September 1, 2022 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Teach input_data to see parameters in Python tutorial
2 participants