Skip to content

Commit

Permalink
Address review comments
Browse files Browse the repository at this point in the history
Co-authored-by: Bryan Weber <bryan.w.weber@gmail.com>
  • Loading branch information
ischoegl and bryanwweber committed Aug 4, 2022
1 parent 03649d7 commit 3fa0344
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 10 deletions.
12 changes: 4 additions & 8 deletions interfaces/cython/SConscript
Expand Up @@ -15,10 +15,6 @@ build(dataFiles)
testFiles = localenv.RecursiveInstall("cantera/test/data", "#test/data")
build(testFiles)

exampleFiles = localenv.RecursiveInstall(
"cantera/interfaces/cython/cantera/examples", "#build/python/cantera/examples")
build(exampleFiles)

# Get information needed to build the Python module
script = """\
from sysconfig import *
Expand Down Expand Up @@ -121,12 +117,12 @@ env['python_module'] = mod
env['python_extension'] = ext

localenv.Depends(mod, [ext, dataFiles, testFiles, setup_cfg, readme, license,
"setup.py", "pyproject.toml"])
"setup.py", "pyproject.toml", "cantera/examples/README.txt"])
localenv.Depends(ext, localenv['cantera_staticlib'])

for f in (multi_glob(localenv, "cantera", "py") +
multi_glob(localenv, "cantera/*", "py") +
multi_glob(localenv, "cantera/*/README*", "txt")):
for f in (multi_glob(localenv, 'cantera', 'py') +
multi_glob(localenv, 'cantera/*', 'py') +
multi_glob(localenv, 'cantera/*/*', 'py')):
localenv.Depends(mod, f)

# Determine installation path and install the Python module
Expand Down
4 changes: 2 additions & 2 deletions interfaces/cython/setup.cfg.in
Expand Up @@ -54,8 +54,8 @@ packages =
cantera.data = *.*, */*.*
cantera.test.data = *.*, */*.*
# The module extension needs to be here since we don't want setuptools to
# compile the extension, so there are no `source` files in
# the setup.py extension.
# compile the extension, so there are no ``source`` files in
# the setup.py ``extension`` and we have to treat the module as package data.
cantera = *.pxd, *@module_ext@, examples/*.txt

[options.extras_require]
Expand Down

0 comments on commit 3fa0344

Please sign in to comment.