-
-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect implementation of internal energy in WaterSSTP (liquid-water-IAPWS95) #1315
Comments
speth
added a commit
to speth/cantera
that referenced
this issue
Sep 25, 2022
Partially resolves Cantera#1315
speth
added a commit
to speth/cantera
that referenced
this issue
Sep 25, 2022
The nondimensional EOS should always be dimensionalized to a mass basis using the value of R given in the original source. Values on a molar basis can then be computed consistently using the best available value for the molecular weight of water. Partially resolves Cantera#1315
speth
added a commit
to speth/cantera
that referenced
this issue
Sep 25, 2022
The nondimensional EOS should always be dimensionalized to a mass basis using the value of R given in the original source. Values on a molar basis can then be computed consistently using the best available value for the molecular weight of water. Partially resolves Cantera#1315
speth
added a commit
that referenced
this issue
Sep 25, 2022
The nondimensional EOS should always be dimensionalized to a mass basis using the value of R given in the original source. Values on a molar basis can then be computed consistently using the best available value for the molecular weight of water. Partially resolves #1315
jongyoonbae
pushed a commit
to jongyoonbae/cantera
that referenced
this issue
Feb 2, 2023
Partially resolves Cantera#1315
jongyoonbae
pushed a commit
to jongyoonbae/cantera
that referenced
this issue
Feb 2, 2023
The nondimensional EOS should always be dimensionalized to a mass basis using the value of R given in the original source. Values on a molar basis can then be computed consistently using the best available value for the molecular weight of water. Partially resolves Cantera#1315
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem description
Calculations of the internal energy in the
WaterSSTP
class (YAML model nameliquid-water-IAPWS95
) give thermodynamically inconsistent results, compared to using the identity u = h - P*v and du/dT = cv.Steps to reproduce
System information
main
at 1ab81acAdditional context
This was discovered as part of #1299, which implements Cantera/enhancements#114.
The text was updated successfully, but these errors were encountered: