Fix pip appveyor #529
Fix pip appveyor #529
Conversation
|
Oh, so SCons can finally be installed without the I don't think there's much difference in testing with Python 3.5 vs 3.6. Testing with an older version at least makes sure that we don't accidentally use features that were only introduced in Python 3.6. I know I do all my local development and testing using Python 3.6, so this might be the main source of testing for Python 3.5. I'd rather not expand the build matrix, just because that would slow down all the CI builds. |
pip2 and pip3 used the same cache directory, resulting in a cache invalidation warning because the Python 2 version of a package is not compatible with Python 3. Using --no-cache-dir is recommended in pypa/pip#5250
--egg is removed in pip >= 10.0.0 and is no longer necessary to to install SCons with more recent versions of setuptools
bryanwweber
force-pushed
the
fix_pip_appveyor
branch
from
aede2e6
to
b1a010e
Compare
|
I think the change is that more recent versions of SCons have support for more recent versions of setuptools (or maybe require more recent versions of setuptools). Also, installing from the wheel (because the wheel package is installed) rather than the sdist may have helped. In any case, we would have to downgrade pip on Appveyor (or maybe just not upgrade pip) to keep using the Anyways, this is squashed and should be good to merge now. |
Changes proposed in this pull request:
Should we use Python 3.6 for the builds and tests here? It's probably a good idea to keep testing with Python 3.5 as long as we support that, but I'm not sure we test with Python 3.6 anywhere else (except the conda packages, I guess)