You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The use of magic numbers as type constants should be deprecated throughout Cantera in favor of string types. I.e. type queries should have a signature virtual std::string type() const, like in class ThermoPhase.
Actual Behavior
All current objects in zeroD still use magic numbers with a signature int type() const. While a resolution of this issue in the cython interface is straight-forward, the current structure of the CLIB interface depends on integer-based object creation, i.e. internal integer m_type class variables are still essential.
Steps to reproduce
N/A
The text was updated successfully, but these errors were encountered:
Cantera version
All / current development version (2.5.0a2)
Operating System
All
Python/MATLAB version
N/A
Expected Behavior
The use of magic numbers as type constants should be deprecated throughout Cantera in favor of string types. I.e. type queries should have a signature
virtual std::string type() const
, like in classThermoPhase
.Actual Behavior
All current objects in
zeroD
still use magic numbers with a signatureint type() const
. While a resolution of this issue in the cython interface is straight-forward, the current structure of the CLIB interface depends on integer-based object creation, i.e. internal integerm_type
class variables are still essential.Steps to reproduce
N/A
The text was updated successfully, but these errors were encountered: