Deprecate magic numbers in zeroD CLIB #660
Conversation
ischoegl
force-pushed
the
deprecate-magic-numbers
branch
3 times, most recently
from
ed3c1e2
to
ea3cbf4
Compare
Codecov Report
@@ Coverage Diff @@
## master #660 +/- ##
==========================================
- Coverage 70.78% 70.67% -0.11%
==========================================
Files 373 373
Lines 43447 43512 +65
==========================================
Hits 30754 30754
- Misses 12693 12758 +65
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #660 +/- ##
==========================================
- Coverage 70.78% 70.66% -0.12%
==========================================
Files 372 372
Lines 43443 43507 +64
==========================================
- Hits 30750 30744 -6
- Misses 12693 12763 +70
Continue to review full report at Codecov.
|
ischoegl
force-pushed
the
deprecate-magic-numbers
branch
4 times, most recently
from
a381b35
to
ccdf47a
Compare
ischoegl
force-pushed
the
deprecate-magic-numbers
branch
2 times, most recently
from
49ef505
to
93aa49f
Compare
ischoegl
force-pushed
the
deprecate-magic-numbers
branch
2 times, most recently
from
b4a750b
to
fafc3f7
Compare
|
@speth ... I believe comments are addressed.
|
ischoegl
force-pushed
the
deprecate-magic-numbers
branch
from
fafc3f7
to
e219352
Compare
ischoegl
force-pushed
the
deprecate-magic-numbers
branch
2 times, most recently
from
f554df9
to
e7a759f
Compare
ischoegl
force-pushed
the
deprecate-magic-numbers
branch
3 times, most recently
from
e485bb2
to
e79bea3
Compare
|
WIP ... at this point, I finally have a working toolchain for matlab. I will report once the remaining issues are addressed. |
ischoegl
force-pushed
the
deprecate-magic-numbers
branch
4 times, most recently
from
c8ed842
to
d6b4efa
Compare
|
@speth ... Matlab testing is now complete: the example script |
There was a problem hiding this comment.
I think the only decision to be made here is on the Matlab version requirement. If changing this to support Matlab < 2016b is easy, then I would say we should do that. If it's annoying to refactor to do so, I don't really have a problem with setting that as the version requirement.
ischoegl
force-pushed
the
deprecate-magic-numbers
branch
2 times, most recently
from
6d36964
to
c39279d
Compare
* add deprecation warning for int ReactorBase::type() (to be changed after Cantera 2.5) * introduce temporary std::string ReactorBase::typeStr() (to be renamed after Cantera 2.5) * deprecate all functions using the old call and introduce associated temporary functions
ischoegl
force-pushed
the
deprecate-magic-numbers
branch
from
c39279d
to
5ed11a4
Compare
|
@speth ... thank you for the review. Replacing strings in Matlab was actually quite straight-forward (cell arrays of char arrays), and it's back to being compatible beyond 2016b. |
|
@ischoegl The reason your commits aren't being properly attributed is because the "author" field is being filled in using your GMail address, presumably based on your Git configuration on one of your machines. You can get Github to link these commits to your account by adding that address as an alternate address for your Github account. |
|
@speth ... this leaves me stumped: I have my primary email set to my gmail and backup set to the lsu domain (I added the latter recently). I just looked at my commit and it shows my gmail (!). I.e. I already have both my e-mails associated with the account. |
Please fill in the issue number this pull request is fixing:
Fixes #638
Changes proposed in this pull request:
int ReactorBase::type()(to be changed after Cantera 2.5)std::string ReactorBase::typeStr()(to be renamed after Cantera 2.5)Temporary functions are necessary as overloading by return argument type is not possible in C++ (same for overloading of C functions).
PS: Updates are threaded through MATLAB, although I do not have a way to test at the moment (I am unsure whether unit tests are implemented)Edit: MATLAB testing is included in this PR.