Fix python_minimal interface to install Cantera YAML tools #1011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The python_minimal SConscript did't copy cantera yaml tools to python_minimal directory and therefore didn's install these scripts. Signed-off-by: band-a-prend <torokhov-s-a@yandex.ru>
ischoegl
approved these changes
Apr 10, 2021
|
I had to find this issue on 2.5.0-beta but it seems I tested only build of python minimal configuration and never tested it's installation. Thanks for review and merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
The python_minimal SConscript did't copy cantera yaml tools (ck2yaml.py, cti2yaml.py, ctml2yaml.py) to python_minimal directory and therefore didn's install these scripts if
Python Minimalinterface is chosen to build.This patch should fix this issue.
If applicable, fill in the issue number this pull request is fixing
Fixes #
Checklist
scons build&scons test) and unit tests address code coverage