Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update apt repositories before installing dependencies #1056

Merged
merged 1 commit into from
Jun 12, 2021

Conversation

speth
Copy link
Member

@speth speth commented Jun 11, 2021

This should fix some transient CI failures (e.g. #995) when package versions are removed from the remote repositories.

Changes proposed in this pull request

  • Run apt update before apt install ...

If applicable, fill in the issue number this pull request is fixing

Closes #1055

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

This should fix some transient CI failures when package versions are
removed from the remote repositories.

Fixes Cantera#1055
@codecov
Copy link

codecov bot commented Jun 11, 2021

Codecov Report

Merging #1056 (2d99eb5) into main (01bf417) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 2d99eb5 differs from pull request most recent head a1cd9cd. Consider uploading reports for the commit a1cd9cd to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1056   +/-   ##
=======================================
  Coverage   72.59%   72.60%           
=======================================
  Files         356      356           
  Lines       46508    46508           
=======================================
+ Hits        33763    33765    +2     
+ Misses      12745    12743    -2     
Impacted Files Coverage Δ
src/base/AnyMap.cpp 89.61% <0.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e60f513...a1cd9cd. Read the comment docs.

Copy link
Member

@ischoegl ischoegl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@ischoegl ischoegl merged commit 37e37a1 into Cantera:main Jun 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI coverage broke
2 participants