Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-ideal capabilities for 1-D flame model #1079

Merged
merged 19 commits into from Jun 22, 2023
Merged

Non-ideal capabilities for 1-D flame model #1079

merged 19 commits into from Jun 22, 2023

Commits on Jun 22, 2023

  1. Modify the StFlow class to allow non-ideal thermophase 

    The term (cp_k*dT/dt) in the energy equation is replaced by (dh_k/dt).
    @gkogekar
    gkogekar committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    3990a71 View commit details
    Browse the repository at this point in the history

  2. Modification to energy equation based on thermo phase type

    @gkogekar
    gkogekar committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    a75d6d7 View commit details
    Browse the repository at this point in the history

  3. Removing some redundant code as recommended in reviewer's comments.

    @gkogekar
    gkogekar committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    4d5e7f5 View commit details
    Browse the repository at this point in the history

  4. Few modifications required after rebasing the code with current Cantera 

    version
    @gkogekar
    gkogekar committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    0fc099b View commit details
    Browse the repository at this point in the history

  5. Formatting changes

    @gkogekar
    gkogekar committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    2e648da View commit details
    Browse the repository at this point in the history

  6. Addition of global arrays m_hk and m_dhk_dz

    @gkogekar
    gkogekar committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    099e9bd View commit details
    Browse the repository at this point in the history

  7. Few formatting changes

    @gkogekar
    gkogekar committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    36f3e0b View commit details
    Browse the repository at this point in the history

  8. Removing the ideal gas energy equation code block.

    @gkogekar
    gkogekar committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    578d870 View commit details
    Browse the repository at this point in the history

  9. Modifications to the test outputs

    @gkogekar
    gkogekar committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    23dd1f9 View commit details
    Browse the repository at this point in the history

  10. [unittests] Relax tolerances for legacy benchmarks 

    Cantera 3.0 introduces small changes for onedim calculations; as
benchmark files were generated with Cantera 2.6, tolerances need to be
relaxed.
    @ischoegl @gkogekar
    ischoegl authored and gkogekar committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    14bbd2f View commit details
    Browse the repository at this point in the history

  11. Formatting changes (Limiting lines to 88 characters)

    @gkogekar
    gkogekar committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    f5c06fb View commit details
    Browse the repository at this point in the history

  12. Adding a python test for non-ideal flame model

    @gkogekar
    gkogekar committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    33b161b View commit details
    Browse the repository at this point in the history

  13. Updating the description for R-K parameters

    @gkogekar
    gkogekar committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    b526c9b View commit details
    Browse the repository at this point in the history

  14. Formatting changes for Doxygen-style comments

    @gkogekar
    gkogekar committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    6b6f527 View commit details
    Browse the repository at this point in the history

  15. Removing redundant variables

    @gkogekar
    gkogekar committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    0d5e885 View commit details
    Browse the repository at this point in the history

  16. Modification to non-ideal flame testcase to run at 10 bar

    @gkogekar
    gkogekar committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    7617820 View commit details
    Browse the repository at this point in the history

  17. Updating 'missing_ok' flag for python>3.8

    @gkogekar
    gkogekar committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    972fded View commit details
    Browse the repository at this point in the history

  18. Removing the phase check

    @gkogekar
    gkogekar committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    53c2c8f View commit details
    Browse the repository at this point in the history

  19. Updating the failing test

    @gkogekar
    gkogekar committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    a34b39c View commit details
    Browse the repository at this point in the history