Fix AnyValue test failures with old Boost versions #1123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without Boost, the string versions of certain typenames are compiler-dependent. Make sure we use consistent names for all of the types where we end up checking for the names in the test suite. Also, correct comment indicating the minimum version of Boost that has the demangle function. Fixes Cantera#1040
Codecov Report
@@ Coverage Diff @@
## main #1123 +/- ##
==========================================
- Coverage 73.45% 73.45% -0.01%
==========================================
Files 364 364
Lines 47884 47884
==========================================
- Hits 35172 35171 -1
- Misses 12712 12713 +1
Continue to review full report at Codecov.
|
ischoegl
approved these changes
Oct 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without Boost, the string versions of certain typenames are compiler-dependent.
Changes proposed in this pull request
If applicable, fill in the issue number this pull request is fixing
Fixes #1040
Checklist
scons build&scons test) and unit tests address code coverage