Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 3.0.0a1 #1290

Merged
merged 2 commits into from May 23, 2022
Merged

Conversation

ischoegl
Copy link
Member

@ischoegl ischoegl commented May 20, 2022

Changes proposed in this pull request

Start work on 3.0.0.

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

@ischoegl ischoegl requested a review from a team May 20, 2022 22:54
Copy link
Member

@speth speth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Historically, we have started the alpha/beta enumeration from 1, so I think this should ideally be 3.0.0a1.

@bryanwweber
Copy link
Member

Considering the discussion on #1287, it might be worth cherry picking the fix for the Cython job here.

ischoegl and others added 2 commits May 23, 2022 07:20
This hasn't caught any problems yet, it's causing failures due to
changes in setuptools, and it more properly belongs in a separate
workflow because it doesn't need to run on every PR, only on commits to
main.
@ischoegl ischoegl changed the title Bump version to 3.0.0a0 Bump version to 3.0.0a1 May 23, 2022
@speth speth merged commit 48457cc into Cantera:main May 23, 2022
@ischoegl ischoegl deleted the bump-version-to-3.0.0a0 branch May 23, 2022 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants