Deprecate obsolete methods #1295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1295 +/- ##
==========================================
- Coverage 67.26% 67.18% -0.08%
==========================================
Files 314 314
Lines 41887 41904 +17
Branches 16852 16863 +11
==========================================
- Hits 28174 28155 -19
- Misses 11483 11518 +35
- Partials 2230 2231 +1
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
speth
requested changes
May 30, 2022
Reaction::check (renamed from no-argument Reaction::validate) does not require a Kinetics object; nomenclature reflects ReactionRate::check and ReactionRate::validate.
|
@speth ... thanks for the prompt review! Things should be ready to go ... |
speth
approved these changes
May 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
setup_canterascriptsIf applicable, fill in the issue number this pull request is fixing
Closes Cantera/enhancements#135, closes #1280
If applicable, provide an example illustrating new features this pull request is introducing
Checklist
scons build&scons test) and unit tests address code coverage