New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation updates #1296
Documentation updates #1296
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@speth ... thank you for those fixes! I just have some very minor comments.
Co-authored-by: Ingmar Schoegl <ischoegl@lsu.edu>
Codecov Report
@@ Coverage Diff @@
## main #1296 +/- ##
==========================================
- Coverage 67.26% 67.18% -0.08%
==========================================
Files 314 314
Lines 41887 41904 +17
Branches 16852 16863 +11
==========================================
- Hits 28174 28155 -19
- Misses 11483 11518 +35
- Partials 2230 2231 +1
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks - looks good to me!
Changes proposed in this pull request
@internal
and@see
directives in Doxygen docstringseV
is an acceptable unit of activation energyChecklist
scons build
&scons test
) and unit tests address code coverage