Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 3.0.0a2 #1337

Merged
merged 1 commit into from Jul 24, 2022
Merged

Bump version to 3.0.0a2 #1337

merged 1 commit into from Jul 24, 2022

Conversation

ischoegl
Copy link
Member

@ischoegl ischoegl commented Jul 15, 2022

Changes proposed in this pull request

After the merge of #1333 (i.e. CTI/XML are completely removed and remaining Reaction specializations are deprecated, plus yaml2ck is merged), it may be time for updating the alpha version.

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

Copy link
Member

@speth speth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, it's about time for this, what with almost 200 commits since v2.6.0.

However, you forgot about the version number in README.rst.

@codecov
Copy link

codecov bot commented Jul 21, 2022

Codecov Report

Merging #1337 (2328d8b) into main (a2af8fe) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1337      +/-   ##
==========================================
- Coverage   68.06%   68.01%   -0.05%     
==========================================
  Files         318      327       +9     
  Lines       42010    42603     +593     
  Branches    16883    17143     +260     
==========================================
+ Hits        28594    28978     +384     
- Misses      11150    11345     +195     
- Partials     2266     2280      +14     
Impacted Files Coverage Δ
include/cantera/numerics/FuncEval.h 57.89% <0.00%> (-26.73%) ⬇️
src/numerics/FuncEval.cpp 29.16% <0.00%> (-20.84%) ⬇️
src/kinetics/Reaction.cpp 80.08% <0.00%> (-7.93%) ⬇️
include/cantera/zeroD/Reactor.h 59.09% <0.00%> (-5.91%) ⬇️
src/kinetics/ReactionRateFactory.cpp 89.65% <0.00%> (-3.45%) ⬇️
include/cantera/kinetics/ReactionRate.h 80.39% <0.00%> (-1.25%) ⬇️
include/cantera/zeroD/ReactorBase.h 58.53% <0.00%> (-0.44%) ⬇️
src/kinetics/InterfaceKinetics.cpp 73.75% <0.00%> (-0.24%) ⬇️
src/kinetics/Kinetics.cpp 69.32% <0.00%> (-0.10%) ⬇️
src/kinetics/Arrhenius.cpp 96.38% <0.00%> (-0.05%) ⬇️
... and 26 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@ischoegl
Copy link
Member Author

@speth ... thanks for noticing! This should probably wait until #1338 is merged to include the updated third-body detection logic.

@ischoegl ischoegl mentioned this pull request Jul 22, 2022
5 tasks
@speth speth merged commit 0e627ad into Cantera:main Jul 24, 2022
@ischoegl ischoegl deleted the version-3.0.0a2 branch July 31, 2022 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants