Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require C++14 / remove Cygwin #1367

Merged
merged 2 commits into from Aug 25, 2022
Merged

Require C++14 / remove Cygwin #1367

merged 2 commits into from Aug 25, 2022

Conversation

ischoegl
Copy link
Member

@ischoegl ischoegl commented Aug 18, 2022 •
edited

Changes proposed in this pull request

  • Require C++14 for Cantera 3.0
  • Remove Cygwin support

If applicable, fill in the issue number this pull request is fixing

Closes #1368, closes Cantera/enhancements#134

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

@ischoegl ischoegl requested a review from a team August 18, 2022 13:58
@ischoegl
[SCons] Remove Cygwin support
57d3455 
Cygwin support is untested and Cygwin has uncertain usage for Cantera.
Modern replacements such as the Windows Subsystem for Linux v2 (WSL2)
should be used instead.
@ischoegl
[SCons] Make C++14 minimum requirement
4dfcda8 
The minimum language standard to use Boost.Math will be C++14
starting in July 2023
speth
speth approved these changes Aug 25, 2022
View reviewed changes
Copy link
Member

@speth speth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is one way to find out if we have any users compiling on Cygwin.

@ischoegl ischoegl merged commit 943ecc6 into Cantera:main Aug 25, 2022
@ischoegl ischoegl deleted the use-c++14 branch August 25, 2022 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@speth speth speth approved these changes

Assignees
No one assigned
Labels
compiling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Boost throws C++11 deprecation warnings Deprecate/Remove Cygwin support
2 participants
@ischoegl @speth