Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Remove ubuntu-18.04 and add ubuntu-22.04 #1371

Merged
merged 1 commit into from Aug 23, 2022

Conversation

ischoegl
Copy link
Member

@ischoegl ischoegl commented Aug 22, 2022

Changes proposed in this pull request

Update GitHub actions:

  • Remove ubuntu-18.04 (faces brownouts in deprecation period and will be removed in December)
  • Add ubuntu-22.04

If applicable, fill in the issue number this pull request is fixing

Closes #1370

If applicable, provide an example illustrating new features this pull request is introducing

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

@ischoegl ischoegl force-pushed the update-ubuntu-actions branch 2 times, most recently from 25809dc to f2c0829 Compare August 22, 2022 14:44
@ischoegl ischoegl requested a review from a team August 22, 2022 20:44
@bryanwweber
Copy link
Member

bryanwweber commented Aug 23, 2022

Looks like the coverage build is broken? Is that related to the changes here?

@ischoegl
Copy link
Member Author

Looks like the coverage build is broken? Is that related to the changes here?

I don't think so, but something about that CI run is odd. Let me retrigger.

@ischoegl
Copy link
Member Author

Coverage ran through this time ... (which is a relief, as I hadn't touched that test)

Copy link
Member

@bryanwweber bryanwweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bryanwweber bryanwweber merged commit b0076eb into Cantera:main Aug 23, 2022
@ischoegl ischoegl deleted the update-ubuntu-actions branch August 24, 2022 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GH runners for ubuntu 18.04 are deprecated
2 participants