New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preconditioned solver improvements #1377
Merged
Merged
Commits on Aug 26, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 68b039b - Browse repository at this point
Copy the full SHA 68b039bView commit details -
Configuration menu - View commit details
-
Copy full SHA for e56d177 - Browse repository at this point
Copy the full SHA e56d177View commit details -
Configuration menu - View commit details
-
Copy full SHA for c5a5c7d - Browse repository at this point
Copy the full SHA c5a5c7dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 091f170 - Browse repository at this point
Copy the full SHA 091f170View commit details -
[Reactor] Use right preconditioning by default
Using right preconditioning provides a more reliable performance benefit even after the ignition event, allowing the solver to take reasonable timesteps and showing a CPU-time benefit even for a single reactor with the 100-species n-dodecane mechanism.
Configuration menu - View commit details
-
Copy full SHA for d06443e - Browse repository at this point
Copy the full SHA d06443eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9f3ef32 - Browse repository at this point
Copy the full SHA 9f3ef32View commit details -
Configuration menu - View commit details
-
Copy full SHA for e0636ae - Browse repository at this point
Copy the full SHA e0636aeView commit details -
Configuration menu - View commit details
-
Copy full SHA for a8745b2 - Browse repository at this point
Copy the full SHA a8745b2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1697906 - Browse repository at this point
Copy the full SHA 1697906View commit details -
Fix temperature derivatives in reactor Jacobians
Finite differences were being calculated incorrectly due to the arguments to the eval function being misinterpreted.
Configuration menu - View commit details
-
Copy full SHA for e3eaa10 - Browse repository at this point
Copy the full SHA e3eaa10View commit details -
Configuration menu - View commit details
-
Copy full SHA for c5d1a16 - Browse repository at this point
Copy the full SHA c5d1a16View commit details -
[Reactor] Make finite-difference Jacobian available
This is a useful reference for checking analytic or approximate Jacobian formulations, even if it isn't a particularly good Jacobian to use for integration generally.
Configuration menu - View commit details
-
Copy full SHA for c092812 - Browse repository at this point
Copy the full SHA c092812View commit details -
Fix Jacobian term calculations for IdealGasConstPressureMoleReactor
Make exclusion of terms that cause Jacobian to be dense explicit rather than accidental. Include full derivatives of species equation in the derivatives of the energy equation, since this does not affect sparsity.
Configuration menu - View commit details
-
Copy full SHA for db573d8 - Browse repository at this point
Copy the full SHA db573d8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2ee1be3 - Browse repository at this point
Copy the full SHA 2ee1be3View commit details
Commits on Aug 30, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 60e7b65 - Browse repository at this point
Copy the full SHA 60e7b65View commit details -
Configuration menu - View commit details
-
Copy full SHA for ac915cf - Browse repository at this point
Copy the full SHA ac915cfView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.