Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[samples] Do not install Makefile's on Windows #1380

Merged
merged 1 commit into from Aug 28, 2022

Conversation

ischoegl
Copy link
Member

@ischoegl ischoegl commented Aug 27, 2022

Changes proposed in this pull request

Remove Makefile's on Windows builds. GNU make is not standardized on Windows OS; CMake and SCons routes should be used instead.

If applicable, fill in the issue number this pull request is fixing

Closes #1376

If applicable, provide an example illustrating new features this pull request is introducing

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

@ischoegl ischoegl marked this pull request as ready for review August 27, 2022 21:15
@ischoegl ischoegl requested a review from a team August 27, 2022 21:15
Copy link
Member

@speth speth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ischoegl, this looks good to me. And I certainly agree that we should be nudging users toward build systems that actually work on their respective platforms (though I might argue that make doesn't really work very well anywhere...).

@ischoegl
Copy link
Member Author

ischoegl commented Aug 28, 2022

Thanks, @speth!

though I might argue that make doesn't really work very well anywhere...

My own take is that Makefiles can be a valuable resource. My main concern of Cantera's make is Cantera.mak ... it is somewhat hard to follow, as there is a lot of clutter. Many of the compile statements receive the same flags multiple times ...

@ischoegl ischoegl merged commit 372e7af into Cantera:main Aug 28, 2022
@ischoegl ischoegl deleted the remove-make-on-windows branch August 28, 2022 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Makefile on Windows
2 participants