Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SCons] Disable F90 interface default on Apple clang #1390

Merged
merged 1 commit into from
Sep 23, 2022
Merged

[SCons] Disable F90 interface default on Apple clang #1390

merged 1 commit into from
Sep 23, 2022

Conversation

ischoegl
Copy link
Member

@ischoegl ischoegl commented Sep 12, 2022 •
edited
Loading

Changes proposed in this pull request

  • Disable f90_interface by default if Apple clang is detected (i.e. only applies if f90_interface=default)

If applicable, fill in the issue number this pull request is fixing

Bypasses #1379 and #1387

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

@ischoegl ischoegl force-pushed the disable-fortran-on-apple-clang branch from 4512560 to 16cee4c Compare September 12, 2022 16:40
@ischoegl ischoegl changed the title [SCons] Disable Fortran on Apple clang [SCons] Disable F90 interface default on Apple clang Sep 12, 2022
@ischoegl ischoegl marked this pull request as ready for review September 12, 2022 16:54
@ischoegl ischoegl requested a review from a team September 12, 2022 18:02
speth
speth requested changes Sep 22, 2022
View reviewed changes
Copy link
Member

@speth speth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the issues, I agree that this is a sensible change in default, but I don't think this actually resolves either #1379 or #1387.

It would probably make sense to add a comment explaining why the F90 interface is disabled, referencing these issues.

@ischoegl ischoegl force-pushed the disable-fortran-on-apple-clang branch 2 times, most recently from dbdd3f0 to fe03ecd Compare September 22, 2022 21:37
@ischoegl
[SCons] Disable Fortran for Apple clang by default
f8d2425 
On Apple Silicon, the combination of gfortran with Apple clang compilers
causes hard crashes for F90 examples, see Cantera#1379. Changing the default
avoids this issue; users can override by passing 'f90_interface=y' to
SCons. Short-term, the change also bypasses a recently introduced
linking issue on macOS, see Cantera#1387.
@ischoegl ischoegl force-pushed the disable-fortran-on-apple-clang branch from fe03ecd to f8d2425 Compare September 22, 2022 21:40
@ischoegl
Copy link
Member Author

Given the issues, I agree that this is a sensible change in default, but I don't think this actually resolves either #1379 or #1387.

Agreed.

It would probably make sense to add a comment explaining why the F90 interface is disabled, referencing these issues.

I added a comment to the commit message, with an emphasis on #1379. I agree with your assessment of #1387.

speth
speth approved these changes Sep 23, 2022
View reviewed changes
Copy link
Member

@speth speth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks; works for me.

@speth speth merged commit b915c85 into Cantera:main Sep 23, 2022
@ischoegl ischoegl deleted the disable-fortran-on-apple-clang branch September 24, 2022 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@speth speth speth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ischoegl @speth