Fix various CI issues #1399
Merged
Fix various CI issues #1399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1399 +/- ##
==========================================
- Coverage 71.03% 71.03% -0.01%
==========================================
Files 363 363
Lines 51898 51900 +2
Branches 17366 17369 +3
==========================================
+ Hits 36868 36869 +1
- Misses 12683 12684 +1
Partials 2347 2347
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
speth
force-pushed
the
win-setuptools-65.4.0
branch
from
01c8e82
to
fbc93a8
Compare
|
@speth … thanks for addressing these! Regarding the remaining failing examples runners, I cherry-picked @bryanwweber’s fix to #1384 (which should be ready to merge). |
speth
force-pushed
the
win-setuptools-65.4.0
branch
5 times, most recently
from
0f8b616
to
3cd4e0b
Compare
For some reason, setuptools thinks it needs to be able to find the user's home directory to build a wheel, but on Windows this relies on an environment variable (USERPROFILE) that we weren't by default passing in through SCons.
speth
force-pushed
the
win-setuptools-65.4.0
branch
2 times, most recently
from
e794706
to
054fabb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Add testing of the .NET interface on all OSesdeferred for nowIf applicable, fill in the issue number this pull request is fixing
Closes #1397
If applicable, provide an example illustrating new features this pull request is introducing
Checklist
scons build&scons test) and unit tests address code coverage