Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed redundant error checks to fix issue #1412 #1413

Merged
merged 1 commit into from Dec 10, 2022

Conversation

ssun30
Copy link
Contributor

@ssun30 ssun30 commented Dec 10, 2022

Changes proposed in this pull request

  • Removes a redundant error check in clib/ct.cpp so external language interfaces can correctly handle errors returned by the method thermo_setDensity and thermo_setMolarDensity.

If applicable, fill in the issue number this pull request is fixing

Closes #1412

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

@codecov
Copy link

codecov bot commented Dec 10, 2022

Codecov Report

Merging #1413 (3c76364) into main (7d86e26) will decrease coverage by 0.37%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1413      +/-   ##
==========================================
- Coverage   71.16%   70.79%   -0.38%     
==========================================
  Files         373      373              
  Lines       52276    53872    +1596     
  Branches    17374    17579     +205     
==========================================
+ Hits        37204    38139     +935     
- Misses      12718    13332     +614     
- Partials     2354     2401      +47     
Impacted Files Coverage Δ
src/clib/ct.cpp 13.65% <ø> (+0.48%) ⬆️
src/numerics/ODE_integrators.cpp 40.00% <0.00%> (-10.00%) ⬇️
include/cantera/transport/Transport.h 18.69% <0.00%> (-8.34%) ⬇️
include/cantera/kinetics/ReactionData.h 67.85% <0.00%> (-8.15%) ⬇️
src/clib/clib_utils.h 21.42% <0.00%> (-7.15%) ⬇️
include/cantera/thermo/Phase.h 77.77% <0.00%> (-5.90%) ⬇️
src/zeroD/flowControllers.cpp 76.08% <0.00%> (-5.31%) ⬇️
src/numerics/funcs.cpp 66.66% <0.00%> (-5.27%) ⬇️
include/cantera/kinetics/Kinetics.h 30.59% <0.00%> (-5.06%) ⬇️
include/cantera/base/Delegator.h 64.70% <0.00%> (-5.02%) ⬇️
... and 178 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@ischoegl ischoegl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! - The fix looks good to me.

@ischoegl ischoegl merged commit 6042429 into Cantera:main Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting density to invalid values does not return correct error message in language interfaces using Clib
2 participants