[SCons] add AR config option (e.g. to set llvm-ar instead of ar) #1424
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Some systems that are based on Clang/LLVM configurations could rely on
llvm-ar
archiver instead ofar
to package static libraries. The proposed tiny patch offers additional config option (likeCC
,CXX
) to allow user to set appropeate prefered AR variable.Please refer Gentoo Linux issue: https://bugs.gentoo.org/773541
If applicable, fill in the issue number this pull request is fixing
Closes # None
If applicable, provide an example illustrating new features this pull request is introducing
For build and tests of proposed feature the following common SCons configuration was used:
The additional alternate options will be mentioned in appropreate cases.
The system
Sundials 6.5.0
was used until test with sundials from Cantera submodule (Sundials 5.3.0
)The
gfortran
always is used to buildf90_interface
The
cantera.conf
was removed before each build run!Please notice the example of archiver call (
ar
orllvm-ar
):system_sundials="y" system_blas_lapack=n
(lapack support is disabled)system_sundials="y" system_blas_lapack=y blas_lapack_libs="blas,lapack"
AR=llvm-ar CC=clang CXX=clang++ system_sundials="y" system_blas_lapack=n
(lapack support is disabled)AR=llvm-ar CC=clang CXX=clang++ system_sundials="y" system_blas_lapack=y blas_lapack_libs="blas,lapack"
AR=llvm-ar CC=clang CXX=clang++ system_sundials="n" system_blas_lapack=y blas_lapack_libs="blas,lapack"
Checklist
scons build
&scons test
) and unit tests address code coverage