Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Equil] Handle factorization errors in initial estimator #1479

Merged
merged 1 commit into from
Apr 17, 2023

Conversation

speth
Copy link
Member

@speth speth commented Apr 17, 2023

Changes proposed in this pull request

  • Catch and ignore factorization errors in ChemEquil::estimateElementPotentials

If applicable, fill in the issue number this pull request is fixing

Closes #1473

If applicable, provide an example illustrating new features this pull request is introducing

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Merging #1479 (6d808f6) into main (055a530) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main    #1479      +/-   ##
==========================================
- Coverage   70.05%   70.05%   -0.01%     
==========================================
  Files         377      377              
  Lines       57788    57789       +1     
  Branches    19410    19410              
==========================================
  Hits        40482    40482              
- Misses      14745    14747       +2     
+ Partials     2561     2560       -1     
Impacted Files Coverage Δ
src/equil/ChemEquil.cpp 68.82% <50.00%> (-0.09%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@speth speth marked this pull request as ready for review April 17, 2023 19:39
Copy link
Member

@ischoegl ischoegl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @speth - looks good to me!

@ischoegl ischoegl merged commit 6e2a5c0 into Cantera:main Apr 17, 2023
@speth speth deleted the fix-1473-intel-equil branch July 23, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression for overconstrained equilibrium on Intel CI
2 participants