Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate target error when building MSI #1505

Merged
merged 1 commit into from Jun 15, 2023
Merged

Conversation

speth
Copy link
Member

@speth speth commented Jun 15, 2023

Changes proposed in this pull request

MSI builds (see here) are currently failing with the error:

scons: *** Two different builders (<class 'SCons.Builder.BuilderBase'> and InstallBuilder) were specified for the same target: include\cantera\base\config.h
File "D:\a\cantera-windows-binaries\cantera-windows-binaries\cantera\site_scons\site_tools\recursiveInstall.py", line 52, in RecursiveInstall

This PR fixes this error.

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

@speth speth merged commit 952e465 into Cantera:main Jun 15, 2023
37 of 38 checks passed
@speth speth deleted the fix-msi-path branch June 15, 2023 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants