Replace Cabinet in clib / update zeroD factory constructors

[ischoegl]

Changes proposed in this pull request

• Make zeroD factory constructors return shared_ptr<ReactorBase>, etc.
• Replace Cabinet by SharedCabinet in clib interface
• Add some unit tests for ctfunc
• Fix deprecation warnings in sofc.py and lithium_ion_battery.py samples

Caveat: Cabinet<Func1> remains as required updates go beyond the scope of this PR. While some functions can be replaced by classes, internal class methods Func1::derivative etc. would need extensive refactoring.

If applicable, fill in the issue number this pull request is fixing

Addresses Cantera/enhancements#164

If applicable, provide an example illustrating new features this pull request is introducing

Checklist

• The pull request includes a clear description of this code change
• Commit messages have short titles and reference relevant issues
• Build passes (scons build & scons test) and unit tests address code coverage
• Style & formatting of contributed code follows contributing guidelines
• The pull request is ready for review

[codecov]

Codecov Report

Merging #1507 (2b8f5ed) into main (ded75f4) will increase coverage by 0.16%.
The diff coverage is 73.17%.

❗ Current head 2b8f5ed differs from pull request most recent head 59e2d64. Consider uploading reports for the commit 59e2d64 to get more accurate results

@@            Coverage Diff             @@
##             main    #1507      +/-   ##
==========================================
+ Coverage   70.25%   70.42%   +0.16%     
==========================================
  Files         375      375              
  Lines       58292    58285       -7     
  Branches    20828    20820       -8     
==========================================
+ Hits        40955    41046      +91     
+ Misses      14351    14229     -122     
- Partials     2986     3010      +24     

Impacted Files	Coverage Δ
src/clib/ctrpath.cpp	0.00% <0.00%> (ø)
src/clib/ctreactor.cpp	6.25% <40.00%> (-0.22%)	⬇️
src/zeroD/FlowDeviceFactory.cpp	56.00% <60.00%> (-19.00%)	⬇️
src/zeroD/ReactorFactory.cpp	77.08% <60.00%> (-11.29%)	⬇️
src/zeroD/WallFactory.cpp	52.17% <60.00%> (-20.05%)	⬇️
interfaces/cython/cantera/reactor.pyx	89.62% <100.00%> (-0.22%)	⬇️
src/clib/ctfunc.cpp	28.00% <100.00%> (+28.00%)	⬆️
src/clib/ctmultiphase.cpp	2.27% <100.00%> (+2.27%)	⬆️

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[speth]

Thanks, @ischoegl. I'm glad to see something that adds a bit of testing for Func1, even if that was somewhat incidental to what you were setting out to do. I had just one suggested change.

[ischoegl]

Thanks, @ischoegl. I'm glad to see something that adds a bit of testing for Func1, even if that was somewhat incidental to what you were setting out to do. I had just one suggested change.

It was indeed incidental. I did some testing for replacement options for the remaining Cabinet<Func1>, where the tests were the quickest way to see whether things worked as expected. Alas, Func1 does need some refactoring that I don't want to tackle at the moment.

[speth]

Thanks, @ischoegl. This looks good to me.