Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update C++ SolutionArray interface to use 'int' #1520

Merged
merged 4 commits into from Jun 29, 2023

Conversation

ischoegl
Copy link
Member

@ischoegl ischoegl commented Jun 29, 2023

Changes proposed in this pull request

  • Use int for all C++ SolutionArray interface methods
  • Fixes MSVC warnings
  • Avoids potential warnings from clib

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

Fixes MSVC compiler warnings
@ischoegl ischoegl mentioned this pull request Jun 29, 2023
5 tasks
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #1520 (c6b24c1) into main (25fee18) will increase coverage by 0.00%.
The diff coverage is 75.43%.

❗ Current head c6b24c1 differs from pull request most recent head bde12f2. Consider uploading reports for the commit bde12f2 to get more accurate results

@@           Coverage Diff           @@
##             main    #1520   +/-   ##
=======================================
  Coverage   70.52%   70.52%           
=======================================
  Files         376      376           
  Lines       58913    58918    +5     
  Branches    21198    21198           
=======================================
+ Hits        41546    41551    +5     
  Misses      14308    14308           
  Partials     3059     3059           
Impacted Files Coverage Δ
src/clib/ctfunc.cpp 32.71% <20.00%> (+0.63%) ⬆️
src/clib/Cabinet.h 54.41% <66.66%> (-0.67%) ⬇️
src/base/SolutionArray.cpp 78.85% <87.80%> (+0.07%) ⬆️
include/cantera/base/SolutionArray.h 94.44% <100.00%> (ø)
src/oneD/StFlow.cpp 82.18% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ischoegl ischoegl requested review from speth and a team and removed request for speth June 29, 2023 21:32
@ischoegl
Copy link
Member Author

@speth ... I cherry-picked the yaml-cpp commit from #1519, so this can all be taken care of at the same time.

Copy link
Member

@speth speth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ischoegl. These updates look fine to me.

@speth speth merged commit 03f5b82 into Cantera:main Jun 29, 2023
37 of 38 checks passed
@ischoegl ischoegl deleted the fix-msvc-warnings branch June 29, 2023 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants