Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes in oneD #1531

Merged
merged 3 commits into from
Jul 6, 2023
Merged

Small fixes in oneD #1531

merged 3 commits into from
Jul 6, 2023

Conversation

ischoegl
Copy link
Member

@ischoegl ischoegl commented Jul 6, 2023

Changes proposed in this pull request

  • Fix bug in FlameBase.set_initial_guess
  • Replace remaining hardcoded c_offset_U reference in Inlet1D::eval
  • Consolidate code in StFlow::evalRightBoundary

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

A new 'unstrained-flow' type was added that was not captured correctly.
The Poisson equation condition was evaluated outside of the
dedicated method.
@ischoegl
Copy link
Member Author

ischoegl commented Jul 6, 2023

This is ready for a review. The failing tests are unrelated - see #1532

@ischoegl ischoegl requested a review from a team July 6, 2023 01:23
@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Merging #1531 (1295b2b) into main (f89efe8) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1531      +/-   ##
==========================================
+ Coverage   70.50%   70.51%   +0.01%     
==========================================
  Files         376      376              
  Lines       59075    59075              
  Branches    21219    21219              
==========================================
+ Hits        41649    41656       +7     
+ Misses      14348    14341       -7     
  Partials     3078     3078              
Impacted Files Coverage Δ
interfaces/cython/cantera/onedim.py 82.63% <100.00%> (ø)
src/oneD/Boundary1D.cpp 55.39% <100.00%> (ø)
src/oneD/StFlow.cpp 82.18% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@speth speth merged commit 22d760c into Cantera:main Jul 6, 2023
34 of 40 checks passed
@ischoegl ischoegl deleted the tweak-oneD branch July 11, 2023 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants