[Kinetics] Implement band aid for plog validations #1553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous set of temperatures used for validation of P-log rates is a somewhat arbitrary set. Some mechanisms fail for 200 K but work fine for 300 K and up. Work-around discussed in Cantera#1405.
ischoegl
added
Input
Codecov Report
@@ Coverage Diff @@
## main #1553 +/- ##
=======================================
Coverage 70.46% 70.46%
=======================================
Files 379 379
Lines 59091 59091
Branches 21228 21228
=======================================
Hits 41641 41641
Misses 14369 14369
Partials 3081 3081
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
speth
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Per discussion in #1405, the previous set of temperatures used for validation of P-log rates is a somewhat arbitrary set. Some mechanisms fail for 200 K but work fine for 300 K and up. This work-around was discussed as a band-aid to make
some relevant mechanisms work (AramcoMech 3.0 / NUIGMech 1.1), although a more long-term solution should be found.
If applicable, fill in the issue number this pull request is fixing
Partially addresses #1405
Checklist
scons build&scons test) and unit tests address code coverage