Fix for Sundials 6.6 behavior changes #1570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do the interpolation required for "advance" explicitly, rather than relying on SUNDIALS to do it as part of the call to CVode() or IDASolve(). This circumvents a change in behavior introduced in SUNDIALS 6.6. Fixes Cantera#1554.
Include the name of the return code flag, not just its numeric value, and the CVODES-generated error message for all errors.
Codecov Report
@@ Coverage Diff @@
## main #1570 +/- ##
==========================================
+ Coverage 70.45% 70.51% +0.05%
==========================================
Files 379 379
Lines 59093 59112 +19
Branches 21230 21232 +2
==========================================
+ Hits 41636 41682 +46
+ Misses 14376 14354 -22
+ Partials 3081 3076 -5
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Previously, values would be returned for the sensitivity at the last internal timestep of the integrator, rather than being interpolated to the user-specified integration time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
CV_NORMAL/IDA_NORMALintegration option which has a breaking change in behavior starting with SUNDIALS 6.6.ReactorandReactorNetmethods asconstwhere possibleReactorNet.advanceto use interpolation correctlyIf applicable, fill in the issue number this pull request is fixing
Resolves #1554
Resolves #1195
Checklist
scons build&scons test) and unit tests address code coverage