Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sphinx argparse #1581

Merged
merged 7 commits into from
Aug 13, 2023
Merged

Sphinx argparse #1581

merged 7 commits into from
Aug 13, 2023

Conversation

ischoegl
Copy link
Member

@ischoegl ischoegl commented Aug 11, 2023

Changes proposed in this pull request

Improve documentation of converter scripts.

If applicable, fill in the issue number this pull request is fixing

Closes #1577

May create pages that could receive website content (see Cantera/enhancements#178)

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

@ischoegl ischoegl requested a review from a team August 11, 2023 12:10
@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #1581 (0539ff5) into main (4b30fa7) will increase coverage by 0.08%.
Report is 4 commits behind head on main.
The diff coverage is 46.15%.

@@            Coverage Diff             @@
##             main    #1581      +/-   ##
==========================================
+ Coverage   70.51%   70.59%   +0.08%     
==========================================
  Files         379      379              
  Lines       59118    59143      +25     
  Branches    21237    21253      +16     
==========================================
+ Hits        41686    41752      +66     
+ Misses      14359    14319      -40     
+ Partials     3073     3072       -1     
Files Changed Coverage Δ
interfaces/cython/cantera/ck2yaml.py 84.16% <0.00%> (ø)
interfaces/cython/cantera/cti2yaml.py 70.87% <50.00%> (-0.13%) ⬇️
interfaces/cython/cantera/ctml2yaml.py 71.81% <50.00%> (-0.10%) ⬇️
interfaces/cython/cantera/yaml2ck.py 62.67% <50.00%> (-0.32%) ⬇️

... and 10 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@speth speth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ischoegl. I think this makes sense, and clearly fits in with Cantera/enhancements#178 without getting too far ahead of ourselves. I had just a couple of minor questions / suggestions.

doc/sphinx/cython/scripts.rst Outdated Show resolved Hide resolved
doc/sphinx/cython/scripts.rst Show resolved Hide resolved
interfaces/cython/cantera/cti2yaml.py Outdated Show resolved Hide resolved
@ischoegl
Copy link
Member Author

ischoegl commented Aug 13, 2023

@speth ... this should likewise be ready. I added module-level ck2yaml autodoc documentation, and also deprecated the --id argument (which had already triggered warnings).

PS: Once we get to 3.0, it may make sense to use argparse for ck2yaml as well, so we get consistent documentation. I also believe that tutorials can be merged into this documentation directly.

@ischoegl ischoegl requested a review from speth August 13, 2023 13:22
@speth
Copy link
Member

speth commented Aug 13, 2023

Yes, I agree that modifying ck2yaml to also use argparse would make sense after the 3.0 release.

@speth speth merged commit 378ff71 into Cantera:main Aug 13, 2023
41 of 42 checks passed
speth added a commit to Cantera/cantera-website that referenced this pull request Aug 13, 2023
@ischoegl ischoegl deleted the sphinx-argparse branch August 13, 2023 20:38
speth added a commit to speth/cantera-website that referenced this pull request Aug 17, 2023
speth added a commit to Cantera/cantera-website that referenced this pull request Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Cantera 3.0 website converter script documentation
2 participants