Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix restoring ImpingingJet from HDF5 #1585

Merged
merged 3 commits into from
Aug 13, 2023
Merged

Fix restoring ImpingingJet from HDF5 #1585

merged 3 commits into from
Aug 13, 2023

Conversation

ischoegl
Copy link
Member

@ischoegl ischoegl commented Aug 11, 2023

Changes proposed in this pull request

If applicable, fill in the issue number this pull request is fixing

Closes #1580

If applicable, provide an example illustrating new features this pull request is introducing

Run samples/python/onedim/stagnation_flame.py example, then

In [1]: import cantera as ct
   ...: gas = ct.Solution('h2o2.yaml')
   ...: flame = ct.ImpingingJet(gas)
   ...: flame.restore('stagnation_flame_data/stagnation_flame.h5', 'mdot-0')
Out[1]:
{'cantera-version': '3.0.0b1',
 'date': 'Fri Aug 11 10:54:37 2023',
 'description': 'mdot = 0.06 kg/m2/s',
 'generator': 'Cantera SolutionArray',
 'git-commit': "'c92138c12'"}

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

@ischoegl ischoegl requested a review from a team August 11, 2023 17:54
@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #1585 (0d854fb) into main (4b30fa7) will increase coverage by 0.07%.
Report is 1 commits behind head on main.
The diff coverage is 40.74%.

@@            Coverage Diff             @@
##             main    #1585      +/-   ##
==========================================
+ Coverage   70.51%   70.58%   +0.07%     
==========================================
  Files         379      379              
  Lines       59118    59134      +16     
  Branches    21237    21253      +16     
==========================================
+ Hits        41686    41739      +53     
+ Misses      14359    14322      -37     
  Partials     3073     3073              
Files Changed Coverage Δ
include/cantera/oneD/Boundary1D.h 57.89% <ø> (+8.91%) ⬆️
src/oneD/Sim1D.cpp 69.20% <20.00%> (-1.23%) ⬇️
src/oneD/Boundary1D.cpp 60.08% <100.00%> (+4.68%) ⬆️

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@speth speth changed the title Fix 1580 Fix restoring ImpingingJet from HDF5 Aug 13, 2023
Copy link
Member

@speth speth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ischoegl. Just one very minor fixup, I think.

test/python/test_onedim.py Outdated Show resolved Hide resolved
@ischoegl
Copy link
Member Author

Thanks, @speth ... I believe this is ready to merge.

@ischoegl ischoegl requested a review from speth August 13, 2023 01:53
@speth speth merged commit 7df2adb into Cantera:main Aug 13, 2023
41 of 42 checks passed
@ischoegl ischoegl deleted the fix-1580 branch August 13, 2023 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Unable to restore ImpingingJet from HDF5
2 participants