Backport changes to 3.0 branch for Python 3.12 and NumPy 2.0 support #1719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
build 1.0 comes with multiple breaking changes
Eliminates the confusing "python_sdist=yes" option Resolves Cantera#1678
When building the sdist via scons, the cython step was running twice because of the conditional. In addition, we were getting a warning about building the extension from multiple source files. These changes resolve both problems by cythonizing once if the files aren't present and only including the C++ sources in the extension.
NumPy 2.0 does not support Python 3.8, so we need to special case that version.
Update dependencies for Cython/Sdist packages
bryanwweber
force-pushed
the
bryan-backport-numpy2-and-py312
branch
from
3adcfb0
to
2696444
Compare
GitHub Actions runner was updated to remove Clang 12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
mainto3.0to support Python 3.12 and NumPy 2.0Checklist
scons build&scons test) and unit tests address code coverage