Cleaning up pressure implementation in MixtureFugacityTP and derived classes
#436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d classes. Cleaning up `RedlichKwongMFTP:pressure()` and removing `m_Pcurrent` as a cached value in `RedlichKwongMFTP` and `MixtureFugacityTP`. The stored value was only ever called in one location `RedlichKwongMFTP:getPartialMolarVolumes()`, and the function call it replaced (`RedlichKwongMFTP:pressure()`) is not all that involved.
Codecov Report
@@ Coverage Diff @@
## master #436 +/- ##
==========================================
+ Coverage 57.44% 57.44% +<.01%
==========================================
Files 377 377
Lines 40273 40264 -9
Branches 6701 6700 -1
==========================================
- Hits 23133 23130 -3
+ Misses 15178 15173 -5
+ Partials 1962 1961 -1
Continue to review full report at Codecov.
|
|
I don't know enough to understand what the codecov/patch failure is telling me, nor how to fix it. Can someone spell it out a little bit for me? Thanks. |
|
I would regard it as mainly informational -- it's just saying that the lines changed in the patch are less well-covered by the test suite than average. It's not an impediment to merging the PR. |
|
Okay, thanks - I think that comes as no big surprise to either of us :). Working on addressing that, now…
… On Feb 21, 2017, at 2:04 PM, Ray Speth ***@***.***> wrote:
I would regard it as mainly informational -- it's just saying that the lines changed in the patch are less well-covered by the test suite than average. It's not an impediment to merging the PR.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#436 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEgvvIesCbi653C73Ep08Gh0liabFzV9ks5re1F6gaJpZM4MHoIo>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
-Removes
m_Pcurrentas a cached value inMixtureFugacityTPand derived classes (RedlichKwongMFTP).-Replaces the one time this value was ever used (in
RedlichKwongMFTP::getPartialMolarVolumes) with a direct call toRedlichKwongMFTP::pressure(), which now returns the EoS-calculated pressure value (it previously returned the previously stored m_Pcurrent).