Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PureFluid] Use pressure criteria to decide phase #839

Merged
merged 1 commit into from Apr 5, 2020

Commits on Apr 3, 2020

  1. [PureFluid] Use pressure criteria to decide phase

    Use the pressure compared with the saturation pressure to decide gas or
    liquid phase, rather than temperature. This change is required because
    for some substances, the saturation temperature for low values of the
    pressure was outside the limits of the equation of state, resulting
    in convergence errors in the saturation solver.
    
    Since phaseOfMatter can throw, we need to translate exceptions in
    the Cython interface as well.
    
    Add tests to prevent regression with cases identifed in Cantera#786.
    Fixes Cantera#786.
    bryanwweber committed Apr 3, 2020
    Copy the full SHA
    f4c3dc8 View commit details
    Browse the repository at this point in the history