-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update libcantera-devel #35
Conversation
3c44415
to
10ccfe0
Compare
8f810ef
to
42de2bb
Compare
This shouldn't be needed, as we only rely on the header portions of the library? The concern I have is that this will then bring in |
Since |
Ah, if |
42de2bb
to
0198de3
Compare
@bryanwweber ... it is ready now. I also just confirmed that
and
have the expected dependencies. PS: since the latest GH Action, the only change was to remove a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two small things
0198de3
to
55861c6
Compare
@bryanwweber ... thanks! Things are taken care of. I triggered a GH Action to build the packages just to make sure. |
55861c6
to
c5f9aa5
Compare
6c20057
to
4f36096
Compare
@bryanwweber ... I documented the issues with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another couple small clarifications here 😊
4f36096
to
1cae0bf
Compare
@bryanwweber ... fixed things per comments. I also caught one extra-level introduced by copying of some folders of the |
1cae0bf
to
29a0b77
Compare
@bryanwweber ... I'd suggest to table the discussion on whether or not to package 'broken' |
1dd5558
to
835239a
Compare
835239a
to
a3870a3
Compare
@bryanwweber …. Now that Cantera/cantera#1366 is merged, the missing SCons option can be added here. |
Using artifacts from a CI run on GitHub Actions, I have confirmed that #37 is resolved on Linux. Tests on windows revealed issues beyond #37, although some of the build routes are broken even for a regular install (see Cantera/cantera#1375 etc.) and thus need to be taken care of upstream first.
And of course, SCons/scons#3664 is again popping up on Windows when trying to use SCons to compile samples ... (although it does appear like a resolution of that issue may be on the horizon). Edit: Summarizing, this PR resolves issues on Linux; I'd suggest to address remaining issues with macOS and Windows in follow-up PR's |
This PR includes some minor updates:
libcantera-devel
Create "clean" sample folders forcxx
andf90
man
pages incantera
libboost
is a dependency forlibcantera-devel
matlab
folder structurepackage_build = True
Closes #37.