Skip to content
This repository has been archived by the owner on Dec 6, 2023. It is now read-only.

board - buttons and background positions fix #202

Merged
merged 1 commit into from Nov 18, 2020
Merged

board - buttons and background positions fix #202

merged 1 commit into from Nov 18, 2020

Conversation

DevoAbhi
Copy link
Contributor

@DevoAbhi DevoAbhi commented Nov 18, 2020

Unallignment and styles of the save and exit button in board component's dashboard.

Issue number - 184

Proposed changes - Fix the positions of the buttons and the background in board component's dashboard and to make the buttons responsive.

Brief description of what is fixed or changed - The buttons are now not overlapping the shapes and the file upload section and they are responsive. Changes done in file 1. board.component.html and 2. board.component.css.

Types of changes - UI changes.

Put an x in the boxes that apply

  • [ x ] Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (Documentation content changed)
  • Other (please describe):

Checklist

Put an x in the boxes that apply

  • [ x ] My code follows the style guidelines of this project
  • [ x ] I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [ x ] My changes generate no new warnings
  • [ x ] My changes does not break the current system and it passes all the current test cases.

Screenshots

cavasboard_buttons_alligned

Other information

Please mention if any other changes need to be done.

@matheusmosca
Copy link
Contributor

Hi @DevoAbhi , your PR has solved the issue #184 on my computer. I think @goliakshay357 can merge it.

@goliakshay357
Copy link
Member

Awesome! Looks good to me!
Thanks for the contribution :)

@goliakshay357 goliakshay357 merged commit 4b0d8d0 into Canvasbird:master Nov 18, 2020
@goliakshay357
Copy link
Member

@all-contributors please add @DevoAbhi for code.

@allcontributors
Copy link
Contributor

@goliakshay357

I've put up a pull request to add @DevoAbhi! 🎉

@DevoAbhi
Copy link
Contributor Author

Thanks @matheusmosca and @goliakshay357 for merging my pull request.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants