Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feature working fine for large screens and looks good to go 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DevoAbhi I just now found that it's not appearing appropriately on small screens. Please fix this.
I have now added a check that if the screen width is lesser than 600 then the tooltip will appear on the bottom and never overlap on the password box. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go 👍
Thank you for merging my PR @Kajol-Kumari . Would love to contribute more! |
@Kajol-Kumari Merging this pull request has undone the implementations of #291 , which added ellipses to long folder names, This has happened because an older version of styles.scss was probably used to add implementation for password strength. |
Fixes issues caused due to merging of Canvasbird#306.
Fixes Issues caused due to merging of Canvasbird#306 , which removed certain css properties from styles.scss
Fixes Issues caused due to merging of #306 , which removed certain css properties from styles.scss
Issue that this pull request solves - There is no password strength classifier to prevent the user with a weak password from signup.
Closes: # (issue number)
Proposed changes -
Added a password strength classifier to prevent the user with a weak password from signup.
Brief description of what is fixed or changed -
To add a password strength classifier on the signup page. When they try to sign in with a weak password, they are denied to perform the action. Also, the user can see their password strength as a strength meter moves while they enter the password. They can also toggle the visibility of the password. All the necessary checks are mentioned as a tooltip in the password input box.
Types of changes -
New feature
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that applyScreenshots
Other information
Please mention if any changes are required in the PR.