Skip to content
This repository has been archived by the owner on Dec 6, 2023. It is now read-only.

Add Password Strength Classifier #306

Merged
merged 7 commits into from Dec 29, 2020

Conversation

DevoAbhi
Copy link
Contributor

Issue that this pull request solves - There is no password strength classifier to prevent the user with a weak password from signup.

Closes: # (issue number)

Proposed changes -

Added a password strength classifier to prevent the user with a weak password from signup.

Brief description of what is fixed or changed -

To add a password strength classifier on the signup page. When they try to sign in with a weak password, they are denied to perform the action. Also, the user can see their password strength as a strength meter moves while they enter the password. They can also toggle the visibility of the password. All the necessary checks are mentioned as a tooltip in the password input box.

Types of changes -

New feature

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • [ x ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (Documentation content changed)
  • Other (please describe):

Checklist

Put an x in the boxes that apply

  • [ x ] My code follows the style guidelines of this project
  • [ x ] I have performed a self-review of my own code
  • [ x ] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [ x ] My changes generate no new warnings
  • [ x ] My changes does not break the current system and it passes all the current test cases.

Screenshots

canva-pass-final

Other information

Please mention if any changes are required in the PR.

Copy link
Contributor

@Kajol-Kumari Kajol-Kumari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feature working fine for large screens and looks good to go 👍

Copy link
Contributor

@Kajol-Kumari Kajol-Kumari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DevoAbhi I just now found that it's not appearing appropriately on small screens. Please fix this.
Screenshot from 2020-12-28 22-02-05

@DevoAbhi
Copy link
Contributor Author

@DevoAbhi I just now found that it's not appearing appropriately on small screens. Please fix this.
Screenshot from 2020-12-28 22-02-05

I have now added a check that if the screen width is lesser than 600 then the tooltip will appear on the bottom and never overlap on the password box.
Please confirm if the changes are acceptable.

Copy link
Contributor

@Kajol-Kumari Kajol-Kumari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go 👍

@Kajol-Kumari Kajol-Kumari merged commit 45cb01e into Canvasbird:master Dec 29, 2020
@DevoAbhi
Copy link
Contributor Author

Thank you for merging my PR @Kajol-Kumari . Would love to contribute more!

@DevoAbhi DevoAbhi deleted the password-strength branch December 29, 2020 08:24
@GaganAgarwal77
Copy link
Contributor

GaganAgarwal77 commented Jan 2, 2021

@Kajol-Kumari Merging this pull request has undone the implementations of #291 , which added ellipses to long folder names, This has happened because an older version of styles.scss was probably used to add implementation for password strength.

GaganAgarwal77 added a commit to GaganAgarwal77/canvasboard that referenced this pull request Jan 2, 2021
Fixes issues caused due to merging of Canvasbird#306.
GaganAgarwal77 added a commit to GaganAgarwal77/canvasboard that referenced this pull request Jan 2, 2021
Fixes Issues caused due to merging of Canvasbird#306 , which removed certain css properties from styles.scss
goliakshay357 pushed a commit that referenced this pull request Jan 2, 2021
Fixes Issues caused due to merging of #306 , which removed certain css properties from styles.scss
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants