Skip to content
This repository has been archived by the owner on Dec 6, 2023. It is now read-only.

Issue 327 - Unique folder name create/update #436

Merged
merged 5 commits into from Oct 10, 2021

Conversation

Kevan-Y
Copy link
Contributor

@Kevan-Y Kevan-Y commented Oct 6, 2021

Issue that this pull request solves

Closes: #327

Proposed changes

Brief description of what is fixed or changed

Adding a check to check if the folder names already exist.
Fix the CSS to display error in modal

Types of changes

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (Documentation content changed)
  • Other (please describe):

Checklist

Put an x in the boxes that apply

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • My changes does not break the current system and it passes all the current test cases.

Screenshots

Please attach the screenshots of the changes made in case of change in user interface

Other information

Any other information that is important to this pull request

@goliakshay357
Copy link
Member

goliakshay357 commented Oct 6, 2021

Hello @Kevan-Y,
Thanks for the update. I see one issue when you don't try to change the name.

Steps to produce the bug:

  1. Create a new folder say demo1
  2. Clock on edit folder name.
  3. Now without editing the name, click on green tick.
  4. You get an error for saving the save name.

Generally when you don't change anything in the name, it should accept the existing name.
image

Steps to produce another similar bug:

  1. Create a folder with the same name as an existing one.

@Kevan-Y
Copy link
Contributor Author

Kevan-Y commented Oct 6, 2021

@goliakshay357 Fixed, I also removed some duplicate code that was caused by some commit in master

@goliakshay357 goliakshay357 merged commit 65b288f into Canvasbird:master Oct 10, 2021
@goliakshay357
Copy link
Member

Hello @Kevan-Y,
Thanks for the enhancement :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unique name issue while creating workspace
2 participants