fix: print issue who create crash

Cap-go · Apr 17, 2023 · f638ef2 · f638ef2
1 parent 0eac091
commit f638ef2
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/ios/Plugin/CapacitorUpdater.swift b/ios/Plugin/CapacitorUpdater.swift
@@ -483,7 +483,7 @@ extension CustomError: LocalizedError {
                         mainError = error as NSError
                     }
                 case let .failure(error):
-                    print("\(self.TAG) download error", response.value!, error)
+                    print("\(self.TAG) download error", response?.value ?? "", error)
                     mainError = error as NSError
                 }
             }
@@ -658,7 +658,7 @@ extension CustomError: LocalizedError {
                     setChannel.message = message
                 }
             case let .failure(error):
-                print("\(self.TAG) Error set Channel", response.value!, error)
+                print("\(self.TAG) Error set Channel", response.value ?? "", error)
                 setChannel.message = "Error set Channel \(String(describing: response.value))"
                 setChannel.error = "response_error"
             }
@@ -722,7 +722,7 @@ extension CustomError: LocalizedError {
                 case .success:
                     print("\(self.TAG) Stats send for \(action), version \(versionName)")
                 case let .failure(error):
-                    print("\(self.TAG) Error sending stats: ", response.value!, error)
+                    print("\(self.TAG) Error sending stats: ", response.value ?? "", error)
                 }
             }
         }
@@ -767,7 +767,7 @@ extension CustomError: LocalizedError {
 
     private func saveBundleInfo(id: String, bundle: BundleInfo?) {
         if bundle != nil && (bundle!.isBuiltin() || bundle!.isUnknown()) {
-            print("\(self.TAG) Not saving info for bundle [\(id)]", bundle!.toString())
+            print("\(self.TAG) Not saving info for bundle [\(id)]", bundle?.toString() ?? "")
             return
         }
         if bundle == nil {

diff --git a/ios/Plugin/CapacitorUpdaterPlugin.swift b/ios/Plugin/CapacitorUpdaterPlugin.swift
@@ -122,7 +122,7 @@ public class CapacitorUpdaterPlugin: CAPPlugin {
         let sessionKey = call.getString("sessionKey", "")
         let checksum = call.getString("checksum", "")
         let url = URL(string: urlString)
-        print("\(self.implementation.TAG) Downloading \(url!)")
+        print("\(self.implementation.TAG) Downloading \(url ?? "")")
         DispatchQueue.global(qos: .background).async {
             do {
                 let next = try self.implementation.download(url: url!, version: version, sessionKey: sessionKey)
@@ -138,7 +138,7 @@ public class CapacitorUpdaterPlugin: CAPPlugin {
                 self.notifyListeners("updateAvailable", data: ["bundle": next.toJSON()])
                 call.resolve(next.toJSON())
             } catch {
-                print("\(self.implementation.TAG) Failed to download from: \(url!) \(error.localizedDescription)")
+                print("\(self.implementation.TAG) Failed to download from: \(url ?? "") \(error.localizedDescription)")
                 self.notifyListeners("downloadFailed", data: ["version": version])
                 let current: BundleInfo = self.implementation.getCurrentBundle()
                 self.implementation.sendStats(action: "download_fail", versionName: current.getVersionName())