-
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: Allow resumable download #255
Comments
/bounty $200 |
💎 $200 bounty • CapgoSteps to solve:
Additional notes:ℹ️ If something is not clear ask before working on it, otherwise your chance to rework it is high Additional opportunities:
Thank you for contributing to Cap-go/capacitor-updater! Add a bounty • Share on socials
|
/attempt #255 continuing this from our DM in discord Options |
Isn't the partial download (individual file download) already a partial fix for this? |
@WcaleNieWolny it seems resumable is easier to do than partial. So I had conversation with @neo773 that easier to do, so I want to add this now and partial when ready |
@neo773: Reminder that in 7 days the bounty will become up for grabs, so please submit a pull request before then 🙏 |
The bounty is up for grabs! Everyone is welcome to |
/attempt #255 Options |
I'm sure @neo773 has no trouble speaking for him/herself so there's absolutely no need for you @WcaleNieWolny to speak on their behalf. |
And I am sure he will. I am not saying you should not attempt this. Go ahead, just letting you know what I know about the status of this issue |
@ayewo Feel free to work on it, my attempt wasn't successful |
@neo773 gracias 👍! @riderx
HTTP/1.1 200 OK
Content-Type: application/json
Transfer-Encoding: chunked
Connection: keep-alive
CF-Ray: 7fac66fd7dd30b85-GPS
CF-Cache-Status: DYNAMIC
...
...
Server: cloudflare
Content-Encoding: br
For instance, with caching disabled, if a 100MB download is interrupted after 70% has been downloaded, when the download is resumed, the server will send the remaining 30MB. But with caching enabled, the server will always send the full 100MB any time an end user attempts to continue an interrupted download.
I can assure it is not easier 😀. It is closer in complexity to the partial update feature as it will require opening PRs in this repo as well as the For this repo, the background download logic will have to be refactored so that background downloads can survive network interruptions, end user interruption or termination by the operating system. For the The payment on this issue completely underestimates the effort: it is currently too low. |
Pre-signed URLs have |
Can't you just add "Range: bytes=0-NN" header from iOS or android and then just get the r2 file? I think you can download part of a S3 file https://stackoverflow.com/questions/36436057/s3-how-to-do-a-partial-read-seek-without-downloading-the-complete-file |
To support resumable downloads you need 2 headers. The There are 2 reasons why a new endpoint is required:
As for why caching will need to be disabled for downloads from R2, it because we don't want Cloudflare to ignore the |
That is not true, capgo has a way longer validity due to redis caching the url This used to be true, but is no longer the case |
lol 😂🤣! This was true just 2 weeks ago so not sure what point you are trying to make. In any case your rebuttal doesn't invalidate what I wrote as to why another endpoint is needed. You could have corrected me by saying Martin has since changed it from Anyway just take it easy as I can't possibly be on top of all the changes you and Martin are making✌️. |
I was just trying to inform you about the change to the R2 validity time and I was trying to argue against creating a new endpoint I am sorry if I did not made it clear enough |
@ayewo: Reminder that in 7 days the bounty will become up for grabs, so please submit a pull request before then 🙏 |
@algora-pbc yes, I know but without @riderx's input, I can't really forge ahead. |
@ayewo Bruh, you’re replying to a bot 💀 |
@neo773 I know, right 😁! (I also know that the founders of Algora keep an eye on the bot's email notifications too 😉). |
Roger that 🫡 |
The bounty is up for grabs! Everyone is welcome to |
/attempt #255 Options |
@yashk7oo: Reminder that in 5 days the bounty will become up for grabs, so please submit a pull request before then 🙏 |
The bounty is up for grabs! Everyone is welcome to |
/attempt #255 Options |
@Sambit003: Reminder that in 5 days the bounty will become up for grabs, so please submit a pull request before then 🙏 |
The bounty is up for grabs! Everyone is welcome to |
/attempt #255 Options |
@Samankhalid01: Reminder that in 5 days the bounty will become up for grabs, so please submit a pull request before then 🙏 |
The bounty is up for grabs! Everyone is welcome to |
/attempt #255 |
Is this still active ? |
You can still try to make it yes |
/attempt #255 Options |
Currently, if a network issue happen or the user kill the app, the download is lost and restarted from 0, so implementing resumable download will improve a lot the bandwidth usage and for user with bad connexion
The text was updated successfully, but these errors were encountered: